Changeset 996dd3e in opengl-game for sdl-game.hpp

Timestamp:

May 14, 2021, 1:09:34 AM (4 years ago)

Author:

Dmitry Portnoy <dportnoy@…>

Branches:

feature/imgui-sdl

Children:

a3cefaa

Parents:

9d21aac

Message:

Completely remove storage buffers from the GraphicsPipeline_Vulkan class and start moving storage buffer operations out of the addObject() and updateObject() functions

File:

• sdl-game.hpp (modified) (7 diffs)

sdl-game.hpp

@@ -72 +72 @@
    alignas(16) mat4 view;
    alignas(16) mat4 proj;
+};
+
+// TODO: Use this struct for uniform buffers as well and probably combine it with the VulkanBuffer class
+// Also, probably better to make this a vector of structs where each struct
+// has a VkBuffer, VkDeviceMemory, and VkDescriptorBufferInfo
+struct StorageBufferSet {
+   vector<VkBuffer> buffers;
+   vector<VkDeviceMemory> memory;
+   vector<VkDescriptorBufferInfo> infoSet;
 };
 
@@ -208 +217 @@
       // wouldn't work since the whole pipeline couldn't have a common set of descriptors for the textures
       GraphicsPipeline_Vulkan<ModelVertex> modelPipeline;
+
+      StorageBufferSet storageBuffers_modelPipeline;
 
       // TODO: Maybe make the ubo objects part of the pipeline class since there's only one ubo
@@ -297 +308 @@
                                                    GraphicsPipeline_Vulkan<VertexType>& pipeline,
                                                    const vector<VertexType>& vertices, vector<uint16_t> indices,
-                                                   SSBOType ssbo, bool pipelinesCreated);
+                                                   SSBOType ssbo, StorageBufferSet& storageBuffers,
+                                                   bool pipelinesCreated);
 
       template<class VertexType>
@@ -381 +393 @@
                                                          GraphicsPipeline_Vulkan<VertexType>& pipeline,
                                                          const vector<VertexType>& vertices, vector<uint16_t> indices,
-                                                         SSBOType ssbo, bool pipelinesCreated) {
+                                                         SSBOType ssbo, StorageBufferSet& storageBuffers,
+                                                         bool pipelinesCreated) {
    // TODO: Use the model field of ssbo to set the object's model_base
    // currently, the passed in model is useless since it gets overridden in updateObject() anyway
@@ -403 +416 @@
    pipeline.addObject(obj.vertices, obj.indices, resourceCommandPool, graphicsQueue);
 
+   // TODO: Probably move the resizing to the VulkanBuffer class
+   // First, try moving this out of addObject
    bool resizeStorageBuffer = pipeline.numObjects == pipeline.objectCapacity;
 
    if (resizeStorageBuffer) {
-      resizeStorageBufferSet<VertexType, SSBOType>(pipeline.storageBufferSet, resourceCommandPool, graphicsQueue, pipeline);
+      resizeStorageBufferSet<VertexType, SSBOType>(storageBuffers, resourceCommandPool, graphicsQueue, pipeline);
       pipeline.cleanup();
 
       // Assume the SSBO is always the 2nd binding
-      pipeline.updateDescriptorInfo(1, &pipeline.storageBufferSet.infoSet);
+      // TODO: Figure out a way to make this more flexible
+      pipeline.updateDescriptorInfo(1, &storageBuffers.infoSet);
    }
 
    pipeline.numObjects++;
-
-   updateStorageBuffer(pipeline.storageBufferSet, pipeline.numObjects - 1, obj.ssbo);
 
    // TODO: Figure out why I am destroying and recreating the ubos when the swap chain is recreated,
@@ -421 +435 @@
 
    if (pipelinesCreated) {
+      // TODO: See if I can avoid doing this when recreating the pipeline
       vkDeviceWaitIdle(device);
 
@@ -531 +546 @@
    obj.center = vec3(obj.ssbo.model * vec4(0.0f, 0.0f, 0.0f, 1.0f));
 
-   updateStorageBuffer(pipeline.storageBufferSet, index, obj.ssbo);
-
    obj.modified = false;
 }