Changeset 2f4ff8c in opengl-game for vulkan-utils.hpp

Timestamp:

Jun 20, 2021, 7:05:14 PM (4 years ago)

Author:

Dmitry Portnoy <dportnoy@…>

Branches:

feature/imgui-sdl

Children:

b01b50c

Parents:

90880fb

git-author:

Dmitry Portnoy <dportnoy@…> (06/18/21 16:39:49)

git-committer:

Dmitry Portnoy <dportnoy@…> (06/20/21 19:05:14)

Message:

Change the uniform buffers to always be mapped instead of mapping them every time data needs to be copied

File:

• vulkan-utils.hpp (modified) (1 diff)

vulkan-utils.hpp

@@ -169 +169 @@
       memoryRange.sType = VK_STRUCTURE_TYPE_MAPPED_MEMORY_RANGE;
       memoryRange.memory = bufferMemory;
-      memoryRange.size = size;
+      memoryRange.size = VK_WHOLE_SIZE; // memoryRange.size = size;
+
+      // TODO: Think about the best approach here, and when creating a Vulka buffer.
+      // The issue arises when calling vkMapMemory, because the size passed to it needs to be
+      // VK_WHOLE_SIZE or a multiple of some Vulkan constant. When I create a buffer and matching memory,
+      // the memory size (I believe) needs to be a multiple of the same or a similar constant, while
+      // the buffer can bind to only a part of the memory and I don't think has a size restriction.
+      // As long as I save the actual zize of the allocated memory, I can use that for things
+      // like vkMapMemory, but still continue to use the buffer's size for most operations
 
       vkFlushMappedMemoryRanges(device, 1, &memoryRange);