Changeset 2f4ff8c in opengl-game for sdl-game.cpp

Timestamp:

Jun 20, 2021, 7:05:14 PM (4 years ago)

Author:

Dmitry Portnoy <dportnoy@…>

Branches:

feature/imgui-sdl

Children:

b01b50c

Parents:

90880fb

git-author:

Dmitry Portnoy <dportnoy@…> (06/18/21 16:39:49)

git-committer:

Dmitry Portnoy <dportnoy@…> (06/20/21 19:05:14)

Message:

Change the uniform buffers to always be mapped instead of mapping them every time data needs to be copied

File:

• sdl-game.cpp (modified) (8 diffs)

sdl-game.cpp

@@ -70 +70 @@
                      , gui(nullptr)
                      , window(nullptr)
-                     , vp_mats_modelPipeline()
+                     , uniforms_modelPipeline()
                      , objects_modelPipeline()
                      , score(0)
@@ -93 +93 @@
    vkGetPhysicalDeviceProperties(physicalDevice, &deviceProperties);
 
-   vp_mats_modelPipeline = VulkanBuffer<UBO_VP_mats>(1, deviceProperties.limits.maxUniformBufferRange,
-                                                     deviceProperties.limits.minUniformBufferOffsetAlignment);
+   uniforms_modelPipeline = VulkanBuffer<UBO_VP_mats>(1, deviceProperties.limits.maxUniformBufferRange,
+                                                      deviceProperties.limits.minUniformBufferOffsetAlignment);
 
    objects_modelPipeline = VulkanBuffer<SSBO_ModelObject>(10, deviceProperties.limits.maxStorageBufferRange,
@@ -114 +114 @@
    modelPipeline.addAttribute(VK_FORMAT_R32_UINT, offset_of(&ModelVertex::objIndex));
 
-   createBufferSet(vp_mats_modelPipeline.memorySize(),
+   createBufferSet(uniforms_modelPipeline.memorySize(),
                    VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT,
-                   VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,
+                   VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT,
                    uniformBuffers_modelPipeline);
+
+   uniforms_modelPipeline.map(uniformBuffers_modelPipeline.memory, device);
 
    createBufferSet(objects_modelPipeline.memorySize(),
                    VK_BUFFER_USAGE_TRANSFER_SRC_BIT | VK_BUFFER_USAGE_TRANSFER_DST_BIT
                    | VK_BUFFER_USAGE_STORAGE_BUFFER_BIT,
-                   VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,
+                   VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT,
                    storageBuffers_modelPipeline);
+
+   objects_modelPipeline.map(storageBuffers_modelPipeline.memory, device);
 
    modelPipeline.addDescriptorInfo(VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER,
@@ -445 +449 @@
 
 void VulkanGame::updateScene() {
-   vp_mats_modelPipeline.data()->view = viewMat;
-   vp_mats_modelPipeline.data()->proj = projMat;
+   uniforms_modelPipeline.data()->view = viewMat;
+   uniforms_modelPipeline.data()->proj = projMat;
 
    // TODO: Probably move the resizing to the VulkanBuffer class's add() method
@@ -453 +457 @@
 
    if (objects_modelPipeline.resized) {
+      objects_modelPipeline.unmap(storageBuffers_modelPipeline.memory, device);
+
       resizeBufferSet(storageBuffers_modelPipeline, objects_modelPipeline.memorySize(), resourceCommandPool,
                       graphicsQueue, true);
+
+      objects_modelPipeline.map(storageBuffers_modelPipeline.memory, device);
 
       objects_modelPipeline.resize();
@@ -474 +482 @@
    }
 
-   VulkanUtils::copyDataToMemory(device, vp_mats_modelPipeline.data(), uniformBuffers_modelPipeline.memory[imageIndex],
-                                 0, vp_mats_modelPipeline.memorySize(), false);
-
-   VulkanUtils::copyDataToMemory(device, objects_modelPipeline.data(), storageBuffers_modelPipeline.memory[imageIndex],
-                                 0, objects_modelPipeline.memorySize(), false);
+   VulkanUtils::copyDataToMappedMemory(device, uniforms_modelPipeline.data(), uniforms_modelPipeline.mapped(imageIndex),
+                                       uniformBuffers_modelPipeline.memory[imageIndex],
+                                       uniforms_modelPipeline.memorySize(), true);
+
+   VulkanUtils::copyDataToMappedMemory(device, objects_modelPipeline.data(), objects_modelPipeline.mapped(imageIndex),
+                                       storageBuffers_modelPipeline.memory[imageIndex],
+                                       objects_modelPipeline.memorySize(), true);
 }
 
@@ -1282 +1292 @@
    createSyncObjects();
 
-   createBufferSet(vp_mats_modelPipeline.memorySize(),
+   createBufferSet(uniforms_modelPipeline.memorySize(),
                    VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT,
-                   VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,
+                   VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT,
                    uniformBuffers_modelPipeline);
+
+   uniforms_modelPipeline.map(uniformBuffers_modelPipeline.memory, device);
 
    createBufferSet(objects_modelPipeline.memorySize(),
                    VK_BUFFER_USAGE_TRANSFER_SRC_BIT | VK_BUFFER_USAGE_TRANSFER_DST_BIT
                    | VK_BUFFER_USAGE_STORAGE_BUFFER_BIT,
-                   VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,
+                   VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT,
                    storageBuffers_modelPipeline);
+
+   objects_modelPipeline.map(storageBuffers_modelPipeline.memory, device);
 
    modelPipeline.updateRenderPass(renderPass);
@@ -1315 +1329 @@
    modelPipeline.cleanup();
 
+   uniforms_modelPipeline.unmap(uniformBuffers_modelPipeline.memory, device);
+
    for (size_t i = 0; i < uniformBuffers_modelPipeline.buffers.size(); i++) {
       vkDestroyBuffer(device, uniformBuffers_modelPipeline.buffers[i], nullptr);
       vkFreeMemory(device, uniformBuffers_modelPipeline.memory[i], nullptr);
    }
+
+   objects_modelPipeline.unmap(storageBuffers_modelPipeline.memory, device);
 
    for (size_t i = 0; i < storageBuffers_modelPipeline.buffers.size(); i++) {